Rename NewCriterionTest to CriterionTest.

[gchanan]

Stack from ghstack:

• For CriterionTests, have check_gradgrad actually only affect gradgrad checks. #44060 For CriterionTests, have check_gradgrad actually only affect gradgrad checks.
• Rename NewCriterionTest to CriterionTest. #44056 Rename CriterionTest to NewCriterionTest.
• Merge CriterionTest into NewCriterionTest. #44055 Merge CriterionTest into NewCriterionTest.
• Allow criterion backwards test on modules requiring extra args (i.e. CTCLoss). #44050 Allow criterion backwards test on modules requiring extra args (i.e. CTCLoss).
• Actually run backward criterion tests. #44030 Actually run backward criterion tests.

Differential Revision: D23482573

[dr-ci]

💊 CI failures summary and remediations

As of commit e09100e (more details on the Dr. CI page):

---

• 1/2 failures possibly* introduced in this PR
  • 1/1 non-CircleCI failure(s)
• 1/2 tentatively recognized as flaky ❄️
  • Click here to rerun these jobs

---

❄️ 1 failure tentatively classified as flaky

but reruns have not yet been triggered to confirm:

pytorch_linux_bionic_py3_8_gcc9_coverage_test (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun) ❄️

Sep 02 22:35:47 RuntimeError: Process 2 terminated or timed out after 100.05614304542542 seconds

Sep 02 22:35:47 ====================================================================== 
Sep 02 22:35:47 ERROR [100.100s]: test_backward_node_failure (__main__.ProcessGroupDistAutogradTestWithSpawn) 
Sep 02 22:35:47 ---------------------------------------------------------------------- 
Sep 02 22:35:47 Traceback (most recent call last): 
Sep 02 22:35:47   File "/opt/conda/lib/python3.8/site-packages/torch/testing/_internal/common_distributed.py", line 224, in wrapper 
Sep 02 22:35:47     self._join_processes(fn) 
Sep 02 22:35:47   File "/opt/conda/lib/python3.8/site-packages/torch/testing/_internal/common_distributed.py", line 337, in _join_processes 
Sep 02 22:35:47     self._check_return_codes(elapsed_time) 
Sep 02 22:35:47   File "/opt/conda/lib/python3.8/site-packages/torch/testing/_internal/common_distributed.py", line 375, in _check_return_codes 
Sep 02 22:35:47     raise RuntimeError('Process {} terminated or timed out after {} seconds'.format(i, elapsed_time)) 
Sep 02 22:35:47 RuntimeError: Process 2 terminated or timed out after 100.05614304542542 seconds 
Sep 02 22:35:47  
Sep 02 22:35:47 ---------------------------------------------------------------------- 
Sep 02 22:35:47 Ran 305 tests in 524.691s 
Sep 02 22:35:47  
Sep 02 22:35:47 FAILED (errors=1, skipped=6) 
Sep 02 22:35:47  
Sep 02 22:35:47 Generating XML reports... 
Sep 02 22:35:47 Generated XML report: test-reports/dist-gloo/TEST-ProcessGroupDdpComparisonTestWithSpawn-20200902222702.xml 
Sep 02 22:35:47 Generated XML report: test-reports/dist-gloo/TEST-ProcessGroupDdpUnderDistAutogradTestWithSpawn-20200902222702.xml 
Sep 02 22:35:47 Generated XML report: test-reports/dist-gloo/TEST-ProcessGroupDistAutogradTestWithSpawn-20200902222702.xml 

---

ci.pytorch.org: 1 failed

• Failed: pr/caffe2-pytorch-linux-bionic-rocm3.7-py3.6-test

---

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 5 times.

[facebook-github-bot]

@gchanan merged this pull request in 5973b44.