Migrate gt and gt_ from the TH to Aten (CPU)
#24709
Assignees
Labels
better-engineering
Relatively self-contained tasks for better engineering contributors
module: porting
Issues related to porting TH/THNN legacy to ATen native
triaged
This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Comments
VitalyFedyunin
added
better-engineering
This was referenced Aug 16, 2019
This was referenced Sep 26, 2019
facebook-github-bot
pushed a commit
that referenced
this issue
Sep 28, 2019
…motion. (#26981) Summary: #24606 Migrate ne and ne_ from the TH to Aten (CUDA) #24740 Migrate ne and ne_ from the TH to Aten (CPU) #24573 Migrate gt and gt_ from the TH to Aten (CUDA) #24709 Migrate gt and gt_ from the TH to Aten (CPU) #24556 Migrate eq and eq_ from the TH to Aten (CUDA) #24696 Migrate eq and eq_ from the TH to Aten (CPU) #24568 Migrate ge and ge_ from the TH to Aten (CUDA) #24703 Migrate ge and ge_ from the TH to Aten (CPU) #24582 Migrate le and le_ from the TH to Aten (CUDA) #24719 Migrate le and le_ from the TH to Aten (CPU) Performance characteristics are similar to #25998 This PR migrates comparison ops from TH to ATen and adds type promotion in the same way as in #25998 Pull Request resolved: #26981 Differential Revision: D17635651 Pulled By: ifedan fbshipit-source-id: 6ec7615207f5c248a6dd85fc54c25bd5e6d328e6
zdevito
pushed a commit
to zdevito/ATen
that referenced
this issue
Sep 28, 2019
…motion. (#26981) Summary: pytorch/pytorch#24606 Migrate ne and ne_ from the TH to Aten (CUDA) pytorch/pytorch#24740 Migrate ne and ne_ from the TH to Aten (CPU) pytorch/pytorch#24573 Migrate gt and gt_ from the TH to Aten (CUDA) pytorch/pytorch#24709 Migrate gt and gt_ from the TH to Aten (CPU) pytorch/pytorch#24556 Migrate eq and eq_ from the TH to Aten (CUDA) pytorch/pytorch#24696 Migrate eq and eq_ from the TH to Aten (CPU) pytorch/pytorch#24568 Migrate ge and ge_ from the TH to Aten (CUDA) pytorch/pytorch#24703 Migrate ge and ge_ from the TH to Aten (CPU) pytorch/pytorch#24582 Migrate le and le_ from the TH to Aten (CUDA) pytorch/pytorch#24719 Migrate le and le_ from the TH to Aten (CPU) Performance characteristics are similar to pytorch/pytorch#25998 This PR migrates comparison ops from TH to ATen and adds type promotion in the same way as in pytorch/pytorch#25998 Pull Request resolved: pytorch/pytorch#26981 Differential Revision: D17635651 Pulled By: ifedan fbshipit-source-id: 6ec7615207f5c248a6dd85fc54c25bd5e6d328e6
pdlive215
pushed a commit
to pdlive215/pytorch
that referenced
this issue
Nov 27, 2019
…motion. (pytorch#26981) Summary: pytorch#24606 Migrate ne and ne_ from the TH to Aten (CUDA) pytorch#24740 Migrate ne and ne_ from the TH to Aten (CPU) pytorch#24573 Migrate gt and gt_ from the TH to Aten (CUDA) pytorch#24709 Migrate gt and gt_ from the TH to Aten (CPU) pytorch#24556 Migrate eq and eq_ from the TH to Aten (CUDA) pytorch#24696 Migrate eq and eq_ from the TH to Aten (CPU) pytorch#24568 Migrate ge and ge_ from the TH to Aten (CUDA) pytorch#24703 Migrate ge and ge_ from the TH to Aten (CPU) pytorch#24582 Migrate le and le_ from the TH to Aten (CUDA) pytorch#24719 Migrate le and le_ from the TH to Aten (CPU) Performance characteristics are similar to pytorch#25998 This PR migrates comparison ops from TH to ATen and adds type promotion in the same way as in pytorch#25998 Pull Request resolved: pytorch#26981 Differential Revision: D17635651 Pulled By: ifedan fbshipit-source-id: 6ec7615207f5c248a6dd85fc54c25bd5e6d328e6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Porting TH operators is essential for code simplicity and performance reasons.
Porting guides and Q&A are available in umbrella issue: #24507
Feel free to add @VitalyFedyunin as a reviewer to get a prioritized review.
The text was updated successfully, but these errors were encountered: