Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate digamma and digamma_ from the TH to Aten (CUDA) #24550

Closed
VitalyFedyunin opened this issue Aug 16, 2019 · 0 comments
Closed

Migrate digamma and digamma_ from the TH to Aten (CUDA) #24550

VitalyFedyunin opened this issue Aug 16, 2019 · 0 comments
Assignees
@ifedan
Labels
better-engineering Relatively self-contained tasks for better engineering contributors module: porting Issues related to porting TH/THNN legacy to ATen native triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@VitalyFedyunin
Copy link
Contributor

Porting TH operators is essential for code simplicity and performance reasons.

Porting guides and Q&A are available in umbrella issue: #24507

Feel free to add @VitalyFedyunin as a reviewer to get a prioritized review.
@VitalyFedyunin VitalyFedyunin added better-engineering Relatively self-contained tasks for better engineering contributors module: operators module: porting Issues related to porting TH/THNN legacy to ATen native triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Aug 16, 2019
This was referenced Aug 16, 2019
Closed
Closed
@ifedan ifedan mentioned this issue Aug 22, 2019
Closed
facebook-github-bot pushed a commit that referenced this issue Aug 28, 2019
@ifedan @facebook-github-bot
Migrate digamma\digamma_\polygamma\polygamma_ from the TH to Aten (CP…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
9b10979 
…U) (#25048)

Summary:
#24612
#24550
Pull Request resolved: #25048

Differential Revision: D16996440

Pulled By: ifedan

fbshipit-source-id: 0d76588d179d4c932e3fc284cb399dcfc77bc622
zdevito pushed a commit to zdevito/ATen that referenced this issue Aug 28, 2019
@ifedan @facebook-github-bot
Migrate digamma\digamma_\polygamma\polygamma_ from the TH to Aten (CP…

Verified

This commit was signed with the committer’s verified signature. The key has expired.
phansch Phil Hansch
GPG key ID: B6FA06A6E0E2665B
Expired
Verified
Learn about vigilant mode
c901d9a 
…U) (#25048)

Summary:
pytorch/pytorch#24612
pytorch/pytorch#24550
Pull Request resolved: pytorch/pytorch#25048

Differential Revision: D16996440

Pulled By: ifedan

fbshipit-source-id: 0d76588d179d4c932e3fc284cb399dcfc77bc622
@ifedan ifedan self-assigned this Sep 4, 2019
@ifedan ifedan mentioned this issue Sep 4, 2019
Closed
zdevito pushed a commit to zdevito/ATen that referenced this issue Sep 6, 2019
@ifedan @facebook-github-bot
Migrate digamma and polygamma from the TH to Aten (CUDA) (#25662)
d674141 
Summary:
Close pytorch/pytorch#24550
Close pytorch/pytorch#24612
Pull Request resolved: pytorch/pytorch#25662

Differential Revision: D17205206

Pulled By: ifedan

fbshipit-source-id: 625602ff88940e11e4f7d63bb8950754427b4242
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ifedan ifedan

Labels
better-engineering Relatively self-contained tasks for better engineering contributors module: porting Issues related to porting TH/THNN legacy to ATen native triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate digamma and polygamma from the TH to Aten (CUDA) ifedan/pytorch
2 participants
@VitalyFedyunin @ifedan