Skip to content

Add Intel Crestmont uarch #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2025
Merged

Add Intel Crestmont uarch #299

merged 1 commit into from
Jun 2, 2025

Conversation

fbarchard
Copy link
Collaborator

@fbarchard fbarchard commented May 30, 2025

Darkmont is the uarch used in Sierra Forest
Tested:
cmake .
make cpu-info
sde -srf -- ./cpu-info

Packages:
0: Intel Xeon X5680
1: Intel Xeon X5680
Microarchitectures:
36x Crestmont
Cores:
0: 37 processors (0-36), Intel Crestmont
1: 1 processor (37), Intel Crestmont
2: 1 processor (38), Intel Crestmont
3: 1 processor (39), Intel Crestmont

Was
Microarchitectures:
36x unknown
Cores:
0: 37 processors (0-36), Intel unknown
1: 1 processor (37), Intel unknown

Darkmont is the uarch used in Sierra Forest
Tested:
make cpu-info
sde -srf -- ./cpu-info
Copy link
Contributor

@rrwinterton rrwinterton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@rrwinterton rrwinterton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fbarchard
Copy link
Collaborator Author

Documentation says Intel Grand Ridge uses Crestmont and has a model = B6
But I dont have a way to test this. Its an embedded cpu for routers and such
Intel SDE 9.53.0 has Snow Ridge but not Grand Ridge
Should I add it? If so can you confirm it is family = 6, model = 0xB6 ?

Snow Ridge (predecessor to Grand Ridge) is sse4, 64 bit, 16 threads, meant for embedded apps

sde -snr -- blaze-bin/third_party/cpuinfo/cpu_info
Packages:
0: Intel Xeon X5680
1: Intel Xeon X5680
Microarchitectures:
36x unknown
Cores:
0: 37 processors (0-36), Intel unknown
caveat - sde has the wrong 'package' name for Snowridge

Since Snow Ridge is not supported in uarch.c and Grand Ridge is not easily tested, I think hold off adding the support?

Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@malfet malfet merged commit 88b498b into pytorch:main Jun 2, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants