Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove TRT version restriction #3435

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

zewenli98
Copy link
Collaborator

Description

It seems due to the tensorrt version restriction (now it's tensorrt-cu12>=10.8.0,<10.9.0) in the pyproject file, which made all tests install the same TRT.

Fixes #3434

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@zewenli98 zewenli98 self-assigned this Mar 11, 2025
@github-actions github-actions bot added the component: build system Issues re: Build system label Mar 11, 2025
@github-actions github-actions bot requested a review from narendasan March 11, 2025 20:56
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should modify the future trt jobs to edit this restriction itself instead of changing the version in main since its basically allowing people to install unverified builds

@zewenli98
Copy link
Collaborator Author

zewenli98 commented Mar 11, 2025

I think we should modify the future trt jobs to edit this restriction itself instead of changing the version in main since its basically allowing people to install unverified builds

yeah, I just wanted to have a quick try but it seems even we remove the restriction it's going to install the latest TRT.

@zewenli98 zewenli98 marked this pull request as draft March 11, 2025 22:48
@zewenli98 zewenli98 force-pushed the fix_auto_trigger_latest_trt_CI_tests branch from 3130d37 to 9621a44 Compare March 11, 2025 23:00
@github-actions github-actions bot removed the component: build system Issues re: Build system label Mar 11, 2025
@zewenli98 zewenli98 force-pushed the fix_auto_trigger_latest_trt_CI_tests branch from 09d5e0a to f4e91be Compare March 12, 2025 02:16
@github-actions github-actions bot added the component: build system Issues re: Build system label Mar 12, 2025
@github-actions github-actions bot removed the component: build system Issues re: Build system label Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug] TRT version mismatch on CI tests
3 participants