feat: Support flashinfer.rmsnorm #3424
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…add flashinfer.rmsnorm support test case
github-actions
bot
added
component: tests
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
bowang007
requested review from
narendasan,
chohk88,
zewenli98,
apbose and
cehongwang
bowang007
changed the title
peri044
reviewed
Mar 4, 2025
Comment on lines
+12
to
+16
| @torch.library.custom_op("flashinfer::rmsnorm", mutates_args=()) # type: ignore[misc] | ||
| def flashinfer_rmsnorm( | ||
| input: torch.Tensor, weight: torch.Tensor, eps: float = 1e-6 | ||
| ) -> torch.Tensor: | ||
| return flashinfer.norm.rmsnorm(input, weight) |
There was a problem hiding this comment.
we don't need this registration since you can directly use torch.ops.flashinfer.rmsnorm
There was a problem hiding this comment.
narendasan
reviewed
Mar 5, 2025
narendasan
reviewed
Mar 5, 2025
py/torch_tensorrt/dynamo/conversion/plugins/_generate_plugin.py
Outdated
Show resolved
Hide resolved
narendasan
reviewed
Mar 5, 2025
py/torch_tensorrt/dynamo/conversion/plugins/_generate_plugin.py
Outdated
Show resolved
Hide resolved
|
@bowang007 Can you move the auto plugin gen tests to a runner other than the one used for converter tests? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves some issues and support flashinfer.rmsnorm
Checklist: