gh-96019: makeunicodedata decomposition cache bug #96020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions saves a small amount of space (~4.5KB) in the unicodedata module
isidentical
approved these changes
Aug 18, 2022
There was a problem hiding this comment.
Amazing find @cfbolz! Small comment below.
Before:
14397 unique decomposition entries: 28792 bytes
decomp_data: 57588 bytes
After:
12086 unique decomposition entries: 24170 bytes
decomp_data: 48344 bytes
isidentical
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a small bug in
makeunicodedatawhere the caching of decompositions lists was broken because the code was trying to uselist.indexwith two lists of integers to find pre-existing identical decompositions, which always failed. Use a dict with tuple keys instead.