Skip to content

bpo-45855: Replaced deprecated PyImport_ImportModuleNoBlock with PyIm… #30046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 12, 2021
Merged

bpo-45855: Replaced deprecated PyImport_ImportModuleNoBlock with PyIm… #30046

merged 3 commits into from
Dec 12, 2021

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Dec 11, 2021 •
edited by bedevere-bot
Loading

…port_ImportModule

https://bugs.python.org/issue45855

@kumaraditya303
Copy link
Contributor Author

cc @asvetlov

arhadthedev
arhadthedev requested changes Dec 11, 2021
View reviewed changes
tiran
tiran approved these changes Dec 11, 2021
View reviewed changes
Copy link
Member

@tiran tiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

PyImport_ImportModuleNoBlock is basically an alias for PyImport_ImportModule nowadays.

PyObject *
PyImport_ImportModuleNoBlock(const char *name)
{
    return PyImport_ImportModule(name);
}

@asvetlov asvetlov merged commit 41026c3 into python:main Dec 12, 2021
@asvetlov
Copy link
Contributor

Thanks!

@kumaraditya303 kumaraditya303 deleted the deprecated branch December 12, 2021 08:45
@asvetlov asvetlov mentioned this pull request Dec 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arhadthedev arhadthedev arhadthedev requested changes

@asvetlov asvetlov asvetlov approved these changes

@tiran tiran tiran approved these changes

@abalkin abalkin Awaiting requested review from abalkin abalkin is a code owner

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kumaraditya303 @asvetlov @tiran @arhadthedev @the-knights-who-say-ni @bedevere-bot