Skip to content

bpo-45654: freeze runpy module #29903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 9, 2021
Merged

bpo-45654: freeze runpy module #29903

merged 5 commits into from
Dec 9, 2021

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Dec 3, 2021 •
edited by bedevere-bot
Loading

@kumaraditya303 kumaraditya303 requested a review from a team as a code owner December 3, 2021 11:17
@kumaraditya303
Copy link
Contributor Author

cc @gvanrossum

@gvanrossum
Copy link
Member

Did you regen all?

@kumaraditya303
Copy link
Contributor Author

Did you regen all?

Done

@kumaraditya303
Copy link
Contributor Author

@gvanrossum Added news also, anything else left ?

gvanrossum
gvanrossum reviewed Dec 9, 2021
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know by how much the binary size increased?

@kumaraditya303
Copy link
Contributor Author

kumaraditya303 commented Dec 9, 2021 •
edited
Loading

Do you know by how much the binary size increased?

Around 250 ~ KB on windows 11 64 bit

@gvanrossum
Copy link
Member

Okay, that's acceptable. I'll approve and merge then -- the Azure Pipelines PR failure seems a flake.

@gvanrossum gvanrossum merged commit 44b0e76 into python:main Dec 9, 2021
@gvanrossum
Copy link
Member

Thanks for your contribution!

@kumaraditya303 kumaraditya303 deleted the runpy branch December 11, 2021 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kumaraditya303 @gvanrossum @the-knights-who-say-ni @bedevere-bot