Skip to content

Fix typos in the Objects directory #28766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 6, 2021
Merged

Fix typos in the Objects directory #28766

merged 1 commit into from
Oct 6, 2021

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Oct 6, 2021 •
edited by miss-islington
Loading

Like #28744 but for the Objects directory.

[skip issue] Opening a related issue is pending python/psf-infra-meta#130

Automerge-Triggered-By: GH:gpshead

@gpshead gpshead self-assigned this Oct 6, 2021
@gpshead gpshead added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes skip issue skip news docs Documentation in the Doc dir labels Oct 6, 2021
@gpshead
Copy link
Member

gpshead commented Oct 6, 2021

There are ~5 of these PRs, see #28745 (comment) for details on how we're handling them. TL;DR - I'm taking the reviews. Backports to 3.9 and 3.10 are being done (manually) to reduce potential for merge conflicts of other bugfix backports.

@gpshead gpshead closed this Oct 6, 2021
@gpshead gpshead reopened this Oct 6, 2021
@miss-islington
Copy link
Contributor

@cclauss: Status check is done, and it's a success ❌ .

@gpshead gpshead merged commit 5f401f1 into python:main Oct 6, 2021
@miss-islington
Copy link
Contributor

Thanks @cclauss for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @cclauss and @gpshead, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 5f401f10400123afa9171548c432ea3fc37c0736 3.10

@miss-islington
Copy link
Contributor

Sorry @cclauss and @gpshead, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 5f401f10400123afa9171548c432ea3fc37c0736 3.9

@cclauss cclauss deleted the codespell-Objects branch October 7, 2021 06:01
@cclauss cclauss mentioned this pull request Oct 7, 2021
Merged
cclauss added a commit to cclauss/cpython that referenced this pull request Oct 7, 2021
@cclauss
[3.9] Fix typos in the Objects directory (pythonGH-28766)
84e900e 
(cherry picked from commit 5f401f1)
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Oct 7, 2021
@bedevere-bot
Copy link

GH-28795 is a backport of this pull request to the 3.9 branch.

cclauss added a commit to cclauss/cpython that referenced this pull request Oct 7, 2021
@cclauss
[3.10] Fix typos in the Objects directory (pythonGH-28766)
eceefbb 
(cherry picked from commit 5f401f1)
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Oct 7, 2021
@bedevere-bot
Copy link

GH-28797 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit that referenced this pull request Oct 7, 2021
@cclauss
[3.9] Fix typos in the Objects directory (GH-28766) (GH-28795)
960e7b3 
(cherry picked from commit 5f401f1)

Automerge-Triggered-By: GH:JulienPalard
miss-islington pushed a commit that referenced this pull request Oct 7, 2021
@cclauss
[3.10] Fix typos in the Objects directory (GH-28766) (GH-28797)
dcfbe4f 
(cherry picked from commit 5f401f1)

Automerge-Triggered-By: GH:JulienPalard
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpshead gpshead gpshead approved these changes

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Assignees

@gpshead gpshead

Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cclauss @gpshead @miss-islington @bedevere-bot @the-knights-who-say-ni