Skip to content

bpo-44426: Fix use of the C keyword 'default' as a variable name #26798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mdickinson
Copy link
Member

@mdickinson mdickinson commented Jun 19, 2021

The declaration

.. c:function:: Py_ssize_t PyObject_LengthHint(PyObject *o, Py_ssize_t default)

causes Sphinx >= 4.0 to issue a warning about the use of the C keyword default as a variable name. This PR changes default to defaultvalue, which is what's used in the actual abstract.c source.

https://bugs.python.org/issue44426

Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@miss-islington
Copy link
Contributor

Thanks @mdickinson for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-26804 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Jun 19, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 19, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 19, 2021
@bedevere-bot
Copy link

GH-26805 is a backport of this pull request to the 3.9 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants