Skip to content

gh-88435: smtplib make AUTH work with non-ASCII user/pw #26709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

gh-88435: smtplib make AUTH work with non-ASCII user/pw #26709

wants to merge 1 commit into from

Conversation

jrlevine
Copy link

@jrlevine jrlevine commented Jun 13, 2021

EAI mail systems can have UTF-8 usernames and passwords. This makes AUTH use the same encoding as the rest of smtplib

https://bugs.python.org/issue44269

EAI mail systems can have UTF-8 usernames and passwords. This makes AUTH use the same encoding as the rest of smtplib
@jrlevine jrlevine requested a review from a team as a code owner June 13, 2021 17:28
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@jrlevine

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Jul 30, 2021
@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Aug 9, 2022
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests and a NEWS entry.

@bedevere-app
Copy link

bedevere-app bot commented Feb 27, 2024

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@serhiy-storchaka serhiy-storchaka changed the title bpo-44269: smtplib make AUTH work with non-ASCII user/pw gh-88435: smtplib make AUTH work with non-ASCII user/pw Feb 27, 2024
@zware
Copy link
Member

zware commented Oct 23, 2024

This looks like a reasonable change to me, but unfortunately the PR was opened against the wrong branch (3.9 vs main). It will need to be recreated, but the change still applies cleanly to main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants