[2.7] bpo-29165: doc: make extending/newtypes more Python 3 friendly #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PyObject_HEAD_INIT(NULL) can't be used here on Python 3. PyVarObject_HEAD_INIT(NULL, 0) can be used on both of Python 2 and 3.
methane
changed the title
methane
added
docs
serhiy-storchaka
requested changes
Feb 21, 2017
|
|
||
| This line is a bit of a wart; what we'd like to write is:: | ||
|
|
||
| PyObject_HEAD_INIT(&PyType_Type) | ||
| PyVarObject_HEAD_INIT(&PyType_Type, 0) |
There was a problem hiding this comment.
It is worth to explain what 0 means here (it is a historical artifact).
There was a problem hiding this comment.
I want this pull request only copies from Python 3's doc.
| @@ -244,7 +236,7 @@ doesn't do anything. It can't even be subclassed. | |||
| Adding data and methods to the Basic example | |||
| -------------------------------------------- | |||
|
|
|||
| Let's expend the basic example to add some data and methods. Let's also make | |||
| Let's extend the basic example to add some data and methods. Let's also make | |||
There was a problem hiding this comment.
| @@ -965,14 +957,15 @@ Finalization and De-allocation | |||
|
|
|||
| This function is called when the reference count of the instance of your type is | |||
| reduced to zero and the Python interpreter wants to reclaim it. If your type | |||
| has memory to free or other clean-up to perform, put it here. The object itself | |||
| needs to be freed here as well. Here is an example of this function:: | |||
| has memory to free or other clean-up to perform, you can put it here. The | |||
There was a problem hiding this comment.
What is changed in these lines?
There was a problem hiding this comment.
|
I checked diff of Doc/include/*.c between 2.7 and master, and backported many style fixes. I checked |
serhiy-storchaka
approved these changes
Feb 21, 2017
|
thanks |
jaraco
pushed a commit
that referenced
this pull request
Dec 2, 2022
jaraco
pushed a commit
to jaraco/cpython
that referenced
this pull request
Feb 17, 2023
Fixes python#211 Signed-off-by: Filipe Laíns <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.