bpo-37409: Fix ImportWarning regarding __spec__ and __package__ being None #16003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettcannon
approved these changes
Sep 12, 2019
|
@brettcannon I think this can be backported to 3.8 and 3.7 too given the warning was added in 63b8505 (3.5) and the original test was backported to 3.8 and 3.7 too. I can confirm the |
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Sep 12, 2019
|
Thanks @tirkarthi for the PR, and @brettcannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
Thanks @tirkarthi for the PR, and @brettcannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
|
GH-16084 is a backport of this pull request to the 3.7 branch. |
|
GH-16085 is a backport of this pull request to the 3.8 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 13, 2019
…ythonGH-16003) (cherry picked from commit 6e1a30b) Co-authored-by: Xtreak <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Sep 13, 2019
…H-16003) (cherry picked from commit 6e1a30b) Co-authored-by: Xtreak <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Sep 13, 2019
…H-16003) (cherry picked from commit 6e1a30b) Co-authored-by: Xtreak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue37409