Skip to content

IDLE - Capitalize search dialogs' 'Close' button label. #13691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 31, 2019
Merged

IDLE - Capitalize search dialogs' 'Close' button label. #13691

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57736b6
IDLE - Capitalize search dialogs' 'Close' button label.
terryjreedy May 31, 2019
26ebabc
Fix test
terryjreedy May 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Lib/idlelib/idle_test/test_searchbase.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ def setUpClass(cls):

@classmethod
def tearDownClass(cls):
cls.root.update_idletasks()
cls.root.destroy()
del cls.root

Expand Down Expand Up @@ -149,7 +150,7 @@ def test_create_command_buttons(self):
# Look for close button command in buttonframe
closebuttoncommand = ''
for child in self.dialog.buttonframe.winfo_children():
if child['text'] == 'close':
if child['text'] == 'Close':
closebuttoncommand = child['command']
self.assertIn('close', closebuttoncommand)

Expand Down
2 changes: 1 addition & 1 deletion Lib/idlelib/searchbase.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ def create_command_buttons(self):
f = self.buttonframe = Frame(self.top)
f.grid(row=0,column=2,padx=2,pady=2,ipadx=2,ipady=2)

b = self.make_button("close", self.close)
b = self.make_button("Close", self.close)
b.lower()


Expand Down