[3.13] gh-135968: Add iOS binary stubs for strip (GH-135970) #136015
Merged
+7
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds iOS binary stubs for invoking `strip` (cherry picked from commit 0c6c09b) Co-authored-by: Russell Keith-Magee <[email protected]>
This was referenced Jun 27, 2025
freakboy3742
approved these changes
Jun 27, 2025
|
@ned-deily Does this need an RM approval for merge? It's a "new feature", in the sense you'll be able to invoke a strip alias that didn't previously exist... but that's arguably a bug fix in the sense that there are tools (like meson) that expect |
|
I agree that this smells more like a bug than a feature. Considering that this change is isolated to adding resources in the iOS directory, I don't think the involved RMs would object. But you could ask them for forgiveness. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds iOS binary stubs for invoking
strip(cherry picked from commit 0c6c09b)
Co-authored-by: Russell Keith-Magee [email protected]
strip#135968