Skip to content

gh-130396: Move PYOS_LOG2_STACK_MARGIN to internal headers #135928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

gh-130396: Move PYOS_LOG2_STACK_MARGIN to internal headers #135928

wants to merge 2 commits into from
+34 −32

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Jun 25, 2025 •
edited by bedevere-app bot
Loading

Move PYOS_LOG2_STACK_MARGIN, PYOS_STACK_MARGIN,
PYOS_STACK_MARGIN_BYTES and PYOS_STACK_MARGIN_SHIFT macros to pycore_pythonrun.h internal header. Add underscore (_) prefix to the names to make them private.

@vstinner
pythongh-130396: Move PYOS_LOG2_STACK_MARGIN to internal headers
175f103 
Move PYOS_LOG2_STACK_MARGIN, PYOS_STACK_MARGIN,
PYOS_STACK_MARGIN_BYTES and PYOS_STACK_MARGIN_SHIFT macros to
pycore_pythonrun.h internal header. Add underscore (_) prefix to the
names to make them private.
@vstinner vstinner requested a review from markshannon as a code owner June 25, 2025 11:33
@vstinner vstinner added topic-C-API needs backport to 3.14 bugs and security fixes labels Jun 25, 2025
@bedevere-app bedevere-app bot mentioned this pull request Jun 25, 2025
Open
ZeroIntensity
ZeroIntensity reviewed Jun 25, 2025
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be _PyOS instead of _PYOS?

@vstinner
Copy link
Member Author

Shouldn't it be _PyOS instead of _PYOS?

Ok, I renamed the macros.

ZeroIntensity
ZeroIntensity approved these changes Jun 25, 2025
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees
No one assigned
Labels
awaiting merge needs backport to 3.14 bugs and security fixes skip news topic-C-API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vstinner @ZeroIntensity