Remove unnecessary trailing backslashes #135781
Open
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bedevere-app
bot
added
awaiting review
docs
There was a problem hiding this comment.
I don't see any noticeable change in the rendered documentation, but if this affects translations then it's worthwhile. @StanFromIreland, can you confirm?
There was a problem hiding this comment.
When gettext extracts it, it escapes the \. The result looks like this:
#: ../../c-api/extension-modules.rst:245
msgid ""
"``_testsinglephase`` is an internal module used \\ in CPython's self-test "
"suite; your installation may or may not \\ include it."
msgstr ""This will confuse translators, and they may leave it in, which will result in them appearing in the build. A prior similar pr: #135013 We should probably note this in the devguide, I will add it to my list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The trailing backlash doesn't seem to be needed. Besides, they are extracted by Sphinx
gettextbuilder as part of the translation string, which can lead to wrong translation.📚 Documentation preview 📚: https://cpython-previews--135781.org.readthedocs.build/