gh-127146: Skip test_os.test_mode for Emscripten #135764
Merged
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This always fails in the build bot and always passes for me locally. Skip it for now in order to get the build bot running.
|
looks good now |
blockchainGuru1018
approved these changes
Jun 20, 2025
freakboy3742
approved these changes
Jun 21, 2025
There was a problem hiding this comment.
Logged #135783 to track the underlying problem once this is merged.
|
Thanks! |
|
Thanks @hoodmane for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 21, 2025
Temporarily skip test_os.test_mode on Emscripten; this fails consistently on the buildbot, but not on other test configurations. Reported as pythonGH-135783 for follow up. (cherry picked from commit f491125) Co-authored-by: Hood Chatham <[email protected]>
|
GH-135784 is a backport of this pull request to the 3.14 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This always fails in the build bot and always passes for me locally. Skip it for now in order to get the build bot running.