Skip to content

gh-127146: Allow ignored keys to be missing in test_sysconfig #135622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025

Conversation

hoodmane
Copy link
Contributor

@hoodmane hoodmane commented Jun 17, 2025

Fixes the test on Emscripten where userbase can be missing.

Fixes the test on Emscripten where userbase can be missing.
@hoodmane hoodmane requested a review from FFY00 as a code owner June 17, 2025 16:39
@bedevere-app bedevere-app bot added awaiting review tests Tests in the Lib/test dir labels Jun 17, 2025
@hoodmane hoodmane added skip news and removed tests Tests in the Lib/test dir awaiting review labels Jun 17, 2025
@hoodmane hoodmane requested a review from freakboy3742 June 17, 2025 16:39
@hoodmane hoodmane added tests Tests in the Lib/test dir awaiting review labels Jun 17, 2025
@freakboy3742 freakboy3742 added the needs backport to 3.14 bugs and security fixes label Jun 17, 2025
Copy link
Contributor

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@freakboy3742 freakboy3742 merged commit 28c71ee into python:main Jun 18, 2025
87 of 89 checks passed
@miss-islington-app
Copy link

Thanks @hoodmane for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 18, 2025
…ythonGH-135622)

Fixes the test on Emscripten where userbase can be missing.
(cherry picked from commit 28c71ee)

Co-authored-by: Hood Chatham <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Jun 18, 2025

GH-135650 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jun 18, 2025
freakboy3742 pushed a commit that referenced this pull request Jun 18, 2025
…H-135622) (#135650)

Fixes the test on Emscripten where userbase can be missing.
(cherry picked from commit 28c71ee)

Co-authored-by: Hood Chatham <[email protected]>
lkollar pushed a commit to lkollar/cpython that referenced this pull request Jun 19, 2025
…ython#135622)

Fixes the test on Emscripten where userbase can be missing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants