-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
gh-132661: Document t-strings and templatelib
#135229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
davepeck
wants to merge
26
commits into
python:main
Choose a base branch
from
t-strings:docs/pep750-first-pass
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+452
−12
Draft
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
5a8dbfa
Initial commit.
davepeck 09a1e9e
Make clear the preceding discussion about t-strings creating an insta…
pauleveritt ec44c2b
Get the import order sorted.
pauleveritt d8904b6
Correct the Interpolation() calls.
pauleveritt 550aa6d
Add documentation for Interpolation.
pauleveritt a20e058
Convert to use Sphinx modifiers for type, returns, and rtype.
pauleveritt 1f30739
Add an entry to the glossary.
pauleveritt d935dd6
Find any occurrences of f-strings that should also mention t-strings.
pauleveritt 1e47362
Fix doctests for str.templatelib
davepeck 7b660be
Start writing the t-strings part of lexical analysis
davepeck 00a535d
Merge branch 'main' into docs/pep750-first-pass
davepeck fcd74e6
Fix lint issues
davepeck a796f5d
Fix further sphinx warnings
davepeck 21d337c
More!
davepeck d043381
Merge branch 'main' into docs/pep750-first-pass
davepeck 9a0a301
Wrap up lexical analysis updates... I think?
davepeck f2e5ca4
Document the new AST nodes (TemplateStr and Interpolation)
davepeck 8484b81
First pass at documenting BUILD_TEMPLATE and BUILD_INTERPOLATION
davepeck 56ef703
Merge branch 'main' into docs/pep750-first-pass
davepeck 5a8cf1b
Clarify distinction between string.Template and string.templatelib.Te…
davepeck 127ebc6
Simplify the NOTE
davepeck 73e1222
Okay, I'll stop wordsmithing this for now
davepeck 530cb6d
Fix formatting/parameters for TemplateStr/Interpolation AST nodes
davepeck eaec534
Further ast/dis documentation cleanup
davepeck 05b5beb
Substantial updates to string.templatelib.rst docs
davepeck 680189a
Clarify BUILD_INTERPOLATION behavior
davepeck File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PEP is the original change proposal, and it's expected to go go out of date. It's good to have a link to it in the docs (e.g. a “see also” in the main docs for the feature), so people can read the motivation and get at the discussion links, but if there's any other info in the PEP that's relevant to readers, it should go in the docs.
(And yes, the current docs aren't too great at this.)