-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
bpo-30156: Fix a crash in debug build when PYTHONDUMPREFS is set. #1272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-30156: Fix a crash in debug build when PYTHONDUMPREFS is set. #1272
Conversation
Apply an alternate patch from bpo-26811.
@serhiy-storchaka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @tim-one, @benjaminp and @tiran to be potential reviewers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See discussion on the issue.
Excuse me, @Haypo, I have not understood what changes did you request. |
"See discussion on the issue." means see my comment on the issue: http://bugs.python.org/issue30156#msg292239 Basically, I asked if the optimization is worth it. |
To try and help move older pull requests forward, we are going through and backfilling 'awaiting' labels on pull requests that are lacking the label. Based on the current reviews, the best we can tell in an automated fashion is that a core developer requested changes to be made to this pull request. If/when the requested changes have been made, please leave a comment that says, |
I removed the optimization instead: PR #9541. |
Apply an alternate patch from bpo-26811.
https://bugs.python.org/issue30156