Change lock file name from pyproject.lock to poetry.lock #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdispater
force-pushed
the
lock-name
branch
from
490e84b to
f65bd97
Compare
|
Good idea, certainly nicer than prefixing stuff in pyproject.lock 👍 |
Conan-Kudo
approved these changes
Sep 27, 2018
auvipy
approved these changes
Oct 5, 2018
|
Hey there, I think it only missed a changelog message showing why, I've updated my poetry and my docker images started failing to build and it was a bit hard to find the reason why in the end, I found this from the history page |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
This PR changes to lock file name from
pyproject.locktopoetry.lock.See #444 for the reasoning behind this decision.