Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Allow empty repository url if it's already configured #3497

Closed
wants to merge 2 commits into from

Conversation

orlevii
Copy link

@orlevii orlevii commented Dec 17, 2020

Pull Request Check List

Resolves: #issue-number-here

  • Added tests for changed code.
  • Updated documentation for changed code.

I've tested it manually and it works as expected.

How do I write a test for this change?

@sinoroc
Copy link

sinoroc commented Dec 17, 2020

Isn't there something like the repos from pyproject.toml are only for fetch (download) and the repos from poetry config (poetry.toml, etc.) are only for publish (upload)?

@orlevii
Copy link
Author

orlevii commented Dec 17, 2020

@sinoroc What do you mean?

I don't want to specify the repository url in each and every pyporject.toml.

This change allows to configure the repository globally (on the machine) using poetry config, and under the pyporject.toml specify only the repository name to use.

Is there already a way to do that?

@orlevii orlevii force-pushed the allow_empty_repo_url branch from 010a2d8 to 98ba538 Compare December 17, 2020 16:57
@sinoroc
Copy link

sinoroc commented Dec 17, 2020

@orlevii I agree with you. I believe this is how it should be. I disagree with poetry's design decision to have index URLs in the pyproject.toml altogether, as I stated in #3355 (comment). There are some more tickets going in that same direction.

I am just pointing what the current intended behaviour seems to be, as far as I understood it from the following section of the doc for example (and the whole page actually):

I could be mistaken of course.

@orlevii
Copy link
Author

orlevii commented Dec 17, 2020

@sinoroc
Yeah, got your point.
Looks like repositories added with poetry config can be only used for publishing purposes.

(just like shown here: #2940 (comment))

It causes some inconsistencies.. Setting credentials with poetry config http-basic.repo USERNAME PASSWORD is affecting both installation and publishing commands.

Anyway, I hope this issue will be addressed soon.

@Secrus
Copy link
Member

Secrus commented Jun 20, 2022

No activity for a long time. Closing

@Secrus Secrus closed this Jun 20, 2022
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants