-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub Actions CI #142
GitHub Actions CI #142
Conversation
This release includes PyCQA/pyflakes#455
This was shamelessly ripped from https://github.com/twisted/klein/blob/7256d04caf3860e6f3703c02440f4088b545fd18/.github/workflows/cicd.yml with minor modifications.
Codecov Report
@@ Coverage Diff @@
## master #142 +/- ##
=======================================
Coverage 98.69% 98.69%
=======================================
Files 13 13
Lines 1840 1840
Branches 212 212
=======================================
Hits 1816 1816
Misses 12 12
Partials 12 12 Continue to review full report at Codecov.
|
Hrm, I think we should add 2.6 to the matrix. That does seem like an oversight… |
I'm not seeing the workflows running… is that because this is an external PR and not a branch? |
I honestly don't know. GHA is not great with the feedback... if you typo something in the YAML it doesn't tell you so it could be anything. I'll try creating a separate PR that's more obviously correct. |
Nothing seems to be happening on #143, so I guess I can't configure GHA from my fork. |
@twm I'm getting ready for some travel this week but when I'm back in California, I can try making a branch with this and see if that works. |
@twm I added you as an admin to the repo, so you should be able to make a branch with this diff if you can get to it before me. |
Travis is queuing builds for ages.
I've also added Python 3.9 to CI and the package metadata. I notice that 2.6 isn't in CI. Should it still be listed as supported?