Revert "Deprecate raising unittest.SkipTest to skip tests during collection" #9710
+33
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluetech
added
the
needs backport
…ection" This reverts commit 25e657b. Turns out that this *is* a working unittest feature, which pytest should support, so undo the deprecation.
bluetech
force-pushed
the
restore-unittest-skip-module
branch
from
9fa6cb8 to
df9929d
Compare
nicoddemus
reviewed
Feb 23, 2022
nicoddemus
approved these changes
Feb 23, 2022
Co-authored-by: Bruno Oliveira <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 25e657b (pr #8242, see post-merge discussion there).
Turns out that this is a working unittest feature, which pytest should
support, so undo the deprecation.