-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Drop Python3.6 in CI, setup.cfg, and readme. #9442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks @hramezani!
Let's wait a bit to give time for objections in issue #9437, then we can merge.
Only this is that it needs a breaking
changelog entry - see instructions here.
5b56bb0
to
fea58fe
Compare
92de054
to
ef10f49
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for working on this!
I checked out your branch, and in rewrite.py:379
we have:
has_flags = sys.version_info >= (3, 7)
has_flags
is always True now, so the conditions below which use it can be simplified. 👍
ef10f49
to
c4606a7
Compare
Thanks @RonnyPfannschmidt, @asottile, and @nicoddemus for the review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I missed two paragraphs which should have 3.10 added to them, I will apply them myself.
I removed py36 from the required checks. |
5fa42c8
to
b72ad0f
Compare
Thanks @hramezani! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doc/en/index.rst
Outdated
@@ -17,7 +17,7 @@ The ``pytest`` framework makes it easy to write small, readable tests, and can | |||
scale to support complex functional testing for applications and libraries. | |||
|
|||
|
|||
**Pythons**: ``pytest`` requires: Python 3.6, 3.7, 3.8, 3.9, or PyPy3. | |||
``pytest`` requires: Python 3.7+ and PyPy3. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think or
makes more sense here (and below)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also changed Python 3.6+ and PyPy3
to Python 3.6+ or PyPy3
in Features
section of README.
Does it also make sence?
24d6b1d
to
b0e0373
Compare
b0e0373
to
e5bf378
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, will the silencing of Lines 31 to 32 in 1131f23
still be required when 3.6 is dropped? |
Good catch, probably not and can be removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we can merge now, thanks @hramezani!
Part of #9437