Rename pathlib hook parameters #9363
Merged
+128
−124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoddemus
requested review from
RonnyPfannschmidt,
The-Compiler and
bluetech
nicoddemus
added a commit
to nicoddemus/pytest-flakes
that referenced
this pull request
Dec 1, 2021
This follows up asmeurer#42, we decided that using just `fspath` as the new parameter that users should use would be confusing because it is too close to `path` and also we have `fspath` already in some places of the pytest public API (see pytest-dev/pytest#9283). This PR updates the hook affected by this new change in pytest-dev/pytest#9363.
nicoddemus
commented
Dec 1, 2021
bluetech
approved these changes
Dec 2, 2021
RonnyPfannschmidt
approved these changes
Dec 2, 2021
The-Compiler
added a commit
to The-Compiler/pytest
that referenced
this pull request
Dec 3, 2021
The-Compiler
added a commit
that referenced
this pull request
Dec 6, 2021
* Improve reference and path/fspath docs Closes #9283 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fixups * Add explanation * Update wording after #9363 Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
The-Compiler
added a commit
to The-Compiler/pytest
that referenced
this pull request
Dec 6, 2021
The-Compiler
added a commit
to The-Compiler/pytest
that referenced
this pull request
Dec 6, 2021
The-Compiler
added a commit
to The-Compiler/pytest
that referenced
this pull request
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9283