Support the importlib.resources files API in rewritten files #9173
+40
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bernát Gábor <[email protected]>
Signed-off-by: Bernát Gábor <[email protected]>
gaborbernat
changed the title
gaborbernat
changed the title
Signed-off-by: Bernát Gábor <[email protected]>
Signed-off-by: Bernát Gábor <[email protected]>
|
I believe this may also fix #9174 |
nicoddemus
reviewed
Oct 8, 2021
nicoddemus
approved these changes
Oct 9, 2021
|
Thanks @gaborbernat! |
jaraco
reviewed
Oct 10, 2021
| @@ -276,6 +276,14 @@ def get_data(self, pathname: Union[str, bytes]) -> bytes: | |||
| with open(pathname, "rb") as f: | |||
| return f.read() | |||
|
|
|||
| if sys.version_info >= (3, 9): | |||
There was a problem hiding this comment.
Users of Python 3.8 and earlier can also get the files support by using importlib_resources backport. Are you okay with this functionality not being supported in those environments?
There was a problem hiding this comment.
I'm personally fine with that 😊
|
Hello. Is there a release timeline including this fix? Thanks! |
9 tasks
|
you can try it out in 7.0.0rc1 -- it will eventually land in 7.0 proper |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #9169