#7124: Fix --doctest-modules crashing when __main__.py is present
#8949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,2 @@ | |||
| def test_this_is_ignored(): | |||
| assert True | |||
There was a problem hiding this comment.
i do wonder, should a doctest in this file be considered?
There was a problem hiding this comment.
after reading the details, its a clear nope, as its typically unguarded
RonnyPfannschmidt
approved these changes
Jul 27, 2021
4 tasks
RonnyPfannschmidt
pushed a commit
to RonnyPfannschmidt/pytest
that referenced
this pull request
Oct 1, 2021
…is present (pytest-dev#8949) * Fix ``--doctest-modules`` crashing when ``__main__.py`` is present
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, hope you are all doing well. Been a bit busy as of lately but I am hoping to start contributing again, here is an issue outlined in:
#7124
whereby when
--doctest-moduleswas being passed,ImportErroron__main__.pywas raised, causing a crash. I have added a special case for__main__.pyhere, similarly tosetup.py, would welcome any feed back on this approach or if you can guide me to another one if this is incorrect.__main__.pyspecific checks for thedoctestplugincollect_itemhook implementation