fix #8464 wrong root dir when -c is passed #8537
Merged
+26
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoddemus
requested changes
Apr 14, 2021
There was a problem hiding this comment.
Thanks a lot @elbehery95 for the PR!
However I think I wasn't very clear, but the semantics here should be a bit different: if an inifile is passed in the command-line, then we should always use its directory as rootdir. Please see my comments. 👍
nicoddemus
reviewed
Apr 16, 2021
nicoddemus
approved these changes
Apr 16, 2021
…pytest into config_ini_root_8464
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #8464 including a doc update
@nicoddemus let me know your thoughts and feedback