-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix #8464 wrong root dir when -c is passed #8537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @elbehery95 for the PR!
However I think I wasn't very clear, but the semantics here should be a bit different: if an inifile is passed in the command-line, then we should always use its directory as rootdir. Please see my comments. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a ton @elbehery95 for the contribution!
…pytest into config_ini_root_8464
Fix for #8464 including a doc update
@nicoddemus let me know your thoughts and feedback