-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[PR #12744/c947145f backport][8.3.x] Replaced typing.Self
with typing_extensions.Self
#12746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PR #12744/c947145f backport][8.3.x] Replaced typing.Self
with typing_extensions.Self
#12746
Conversation
Fix incorrect Self import from typing instead of typing_extensions. --------- Co-authored-by: Bruno Oliveira <[email protected]> (cherry picked from commit c947145)
updates: - [github.com/astral-sh/ruff-pre-commit: v0.5.2 → v0.5.4](astral-sh/ruff-pre-commit@v0.5.2...v0.5.4) - [github.com/pre-commit/mirrors-mypy: v1.10.1 → v1.11.0](pre-commit/mirrors-mypy@v1.10.1...v1.11.0)
updates: - [github.com/astral-sh/ruff-pre-commit: v0.5.4 → v0.5.5](astral-sh/ruff-pre-commit@v0.5.4...v0.5.5) - [github.com/asottile/pyupgrade: v3.16.0 → v3.17.0](asottile/pyupgrade@v3.16.0...v3.17.0) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
updates: - [github.com/astral-sh/ruff-pre-commit: v0.5.5 → v0.5.6](astral-sh/ruff-pre-commit@v0.5.5...v0.5.6) - [github.com/pre-commit/mirrors-mypy: v1.11.0 → v1.11.1](pre-commit/mirrors-mypy@v1.11.0...v1.11.1) - [github.com/tox-dev/pyproject-fmt: 2.1.4 → 2.2.1](tox-dev/pyproject-fmt@2.1.4...2.2.1)
According to https://pypi.org/project/types-pkg-resources/#history, that package has been supplanted by `types-setuptools`.
* [pre-commit.ci] pre-commit autoupdate updates: - [github.com/astral-sh/ruff-pre-commit: v0.5.6 → v0.5.7](astral-sh/ruff-pre-commit@v0.5.6...v0.5.7) * Apply pyupgrade latest changes Co-authored-by: Pierre Sassoulas <[email protected]>
updates: - [github.com/astral-sh/ruff-pre-commit: v0.5.7 → v0.6.1](astral-sh/ruff-pre-commit@v0.5.7...v0.6.1) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
updates: - [github.com/astral-sh/ruff-pre-commit: v0.6.1 → v0.6.2](astral-sh/ruff-pre-commit@v0.6.1...v0.6.2) - [github.com/pre-commit/mirrors-mypy: v1.11.1 → v1.11.2](pre-commit/mirrors-mypy@v1.11.1...v1.11.2) * Fix sphinx with a more robust fix Until sphinx-contrib/sphinxcontrib-towncrier#92 is resolved. Co-authored-by: Pierre Sassoulas <[email protected]>
I had to cherry-pick several commits regarding pre-commit version updates and type-checking fixes. |
I will not merge myself, would like a second set of eyes to take a look and merge. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, everything is either automated or a cherry-picking it seems (so if the CI is green there's probably no issues with it). Not sure if I we should merge or squash though.
In this case I think merging is appropriate, so the cherry-picked commits are preserved. 👍 |
This is a backport of PR #12744 as merged into main (c947145).
Fixes #11916 (comment)
Importing
Self
fromtyping
breaks the return type on Python 3.9 and under. You should be usingfrom typing_extension import Self
instead.For example, the following code:
Will error with
Returning Any from function declared to return "CheckdocsItem | None" [no-any-return]
on 3.8 & 3.9, but pass on 3.10+ Which can only be worked around by disabling the error entirely in mypy, or doing: