📝🚑 Polish the PR #12264 changelog entry #12563
Merged
+9
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webknjaz
force-pushed
the
maintenance/hotfixes/note/12264--reraise-with-original-tb
branch
3 times, most recently
from
1eec5cb to
cf0e4fc
Compare
It was being rendered inline and now it's not.
webknjaz
force-pushed
the
maintenance/hotfixes/note/12264--reraise-with-original-tb
branch
from
cf0e4fc to
b62974e
Compare
webknjaz
changed the title
webknjaz
commented
Jul 2, 2024
Comment on lines
+8
to
+11
| * ``FixtureDef.cached_result[2]`` is now a tuple ``(exc, tb)`` | ||
| instead of ``exc``. | ||
| * ``SetupState.stack`` failures are now a tuple ``(exc, tb)`` | ||
| instead of ``exc``. |
There was a problem hiding this comment.
Note: It took me a while to understand why this wasn't being displayed as a list in the preview. I inspected the HTML and found out that with this, the markup correctly uses <li>. Then, I saw that the bullets were disabled by inline CSS. And finally, I found the root cause to be https://github.com/pytest-dev/pytest/pull/12326/files#r1662635927.
Nevertheless, the RST markup fix in this PR is correct. The new cosmetic problem is elsewhere, in the theme patches.
webknjaz
commented
Jul 2, 2024
There was a problem hiding this comment.
Change note preview: https://pytest--12563.org.readthedocs.build/en/12563/changelog.html#bug-fixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was being rendered inline and now it's not.