make async tests and tests that return non-None fail instead of warn #12346
Conversation
There was a problem hiding this comment.
👋 Hi Phebe! This looks good to me overall - three things to do:
- Moving the exception definition, as below
- Doing the various TODOs in comments
- Edit the top comment to link to the issue for awareness and auto-closing, and briefly describe the issue.
|
Hi folks, Sorry why is this being done? Is there an issue related to it? |
|
Suggested in #11372 🙂 (and we're at the PyCon US sprints, so most communication about this has been verbal instead of online) |
|
Ahh OK, no worries, thanks @Zac-HD! If possible it helps adding the issue number in the PR description for context. 👍 |
…. Make tests fail instead of raising warning/exception. fix tests. add changelog.
psf-chronographer
bot
added
the
bot:chronographer:provided
|
Did an overhaul of the implementation, I don't think creating exceptions in I also implemented ReturnNotNone, because it felt minimal and similar enough to just get done. Couldn't find an issue to link the newsfragment to though so I just pointed it to this PR. codecov seems somewhat confused, but afaict everything is actually fine. |
jakkdl
changed the title
There was a problem hiding this comment.
Thanks @polkapolka and @jakkdl for your work on this! I'm looking forward to using it myself 😁
| @@ -0,0 +1 @@ | |||
| Async tests will now fail, instead of warning+skipping, if you don't have any suitable plugin installed. | |||
There was a problem hiding this comment.
Traditionally we have marked changelog entries that turned warnings into errors as breaking, to stand out more.
There was a problem hiding this comment.
good to know, feel free to rename the file :)
No description provided.