Switch to new-style pluggy hook wrappers #11123
Merged
+335
−276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoddemus
requested changes
Jun 19, 2023
There was a problem hiding this comment.
Let's wait on pytest-dev/pluggy#405 before moving this forward. 👍
bluetech
force-pushed
the
new-style-wrappers
branch
from
52c1a7e to
147ad6b
Compare
|
Updated, pending pluggy 1.2.0 release (the pluggymain variants should pass). |
bluetech
force-pushed
the
new-style-wrappers
branch
from
147ad6b to
d9290ce
Compare
bluetech
force-pushed
the
new-style-wrappers
branch
from
d9290ce to
b41acae
Compare
|
Rebased, should be good to merge. |
nicoddemus
reviewed
Jul 14, 2023
There was a problem hiding this comment.
Wonder if this should be considered an improvement? Feels more like an internal change that does not affect users, so perhaps trivial would be more appropriate?
There was a problem hiding this comment.
It has some behavioral changes in exception handling, however mostly I want plugin authors to see it, so let's keep it as improvement.
nicoddemus
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11122.