Add warning when testpaths is set but paths are not found by glob #11044
+25
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluetech
reviewed
May 28, 2023
There was a problem hiding this comment.
Thanks @kenny-y-dev, I think this warning is good to have. I left a couple of suggestions.
Co-authored-by: Ran Benita <[email protected]>
Co-authored-by: Ran Benita <[email protected]>
|
Thanks for the changes to the wording, definitely more clear now. Updated the test to reflect the changes. |
bluetech
approved these changes
May 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11013
Used PytestConfigWarning and setting warning_text string for message to follow convention for some of the other warnings, and set stacklevel to 3 so it shows the warning thrown by parse function. Tried to make the message concise, but if unclear please let me know and I can change!
Tested against steps to reproduce from #11006 and warning is shown.