Add new flag to CLI: --config-file
#11036
Merged
+19
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Mahoney <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Chris Mahoney <[email protected]>
nicoddemus
requested changes
May 25, 2023
There was a problem hiding this comment.
Hi @chrimaho, thanks for the contribution!
However please check your Git settings, both main.py and test_config.py have changed entirely.
|
it seems like the newline convention was changed, wen setting ignore whitespace it gets down to a reasonable diff please fix the newline convention |
- `main.py` to commit SHA `310b67b` - `test_config.py` to commit SHA `407b330`
Signed-off-by: Chris Mahoney <[email protected]>
|
Thank you @nicoddemus and @RonnyPfannschmidt. |
nicoddemus
approved these changes
May 25, 2023
|
(Small tip @chrimaho: you can add "Fix #11036" to your PR description to automatically close the issue when it gets merged: https://github.blog/2013-05-14-closing-issues-via-pull-requests/). |
RonnyPfannschmidt
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new flag to CLI:
--config-fileThere is already an exiting flag in the CLI for importing a custom config file:
-c. This change does not change the behaviour of that flag, but simply adds a new flag to execute the same process:--config-file.This change is also in-line with other large Python packages which use the same behaviour:
--config-file CONFIG_FILE. See here.--config FILE. See here.--config-file#11031