Handle NFC/NFD strings that normalize to the same string. #10355
+53
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Zac-HD please advise on how do you feel about this approach. |
Zac-HD
reviewed
Oct 8, 2022
There was a problem hiding this comment.
Off to a great start - don't forget to add yourself to the AUTHORS file!
for more information, see https://pre-commit.ci
itxasos23
commented
Oct 8, 2022
Zac-HD
reviewed
Oct 8, 2022
Zac-HD
reviewed
Oct 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a failed assertion of two strings, if they normalize to the same text, encode them in utf-8, show a message and compare their bytes representation to make it clear where the strings are different.
Closes #3426