-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Update documentation on how pytest.warns affects DeprecationWarning #9291 #10141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @toclarity, appreciate it!
Looks great overall, please take a look at my comments. 😁
**Using with** ``pytest.mark.parametrize`` | ||
|
||
When using :ref:`pytest.mark.parametrize ref` it is possible to parametrize tests | ||
such that some runs raise a warning and others do not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add an example here to illustrate this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we put a link to Parametrizing conditional raising and point out that it is done in a similar way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For example:
This could be achieved in the same way as with exceptions, see
:ref:`parametrizing_conditional_raising` for an example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nicoddemus we have added the link. Please let us know if this is acceptable or if a specific example is needed.
Co-authored-by: Dani Sancas <[email protected]> On-behalf-of: @clarityai-eng <[email protected]> Signed-off-by: Tatiana Ovary <[email protected]>
Co-authored-by: Dani Sancas <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great addition, thanks a lot!
closes #9291
Co-authored-by: Dani Sancas [email protected]
On-behalf-of: @clarityai-eng [email protected]
Signed-off-by: Tatiana Ovary [email protected]