Update documentation on how pytest.warns affects DeprecationWarning #9291 #10141
+47
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoddemus
requested changes
Jul 15, 2022
There was a problem hiding this comment.
Thanks @toclarity, appreciate it!
Looks great overall, please take a look at my comments. 😁
| **Using with** ``pytest.mark.parametrize`` | ||
|
|
||
| When using :ref:`pytest.mark.parametrize ref` it is possible to parametrize tests | ||
| such that some runs raise a warning and others do not. |
There was a problem hiding this comment.
Could you please add an example here to illustrate this?
There was a problem hiding this comment.
could we put a link to Parametrizing conditional raising and point out that it is done in a similar way?
There was a problem hiding this comment.
For example:
This could be achieved in the same way as with exceptions, see
:ref:`parametrizing_conditional_raising` for an example.
There was a problem hiding this comment.
@nicoddemus we have added the link. Please let us know if this is acceptable or if a specific example is needed.
Co-authored-by: Dani Sancas <[email protected]> On-behalf-of: @clarityai-eng <[email protected]> Signed-off-by: Tatiana Ovary <[email protected]>
Co-authored-by: Dani Sancas <[email protected]>
nicoddemus
approved these changes
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #9291
Co-authored-by: Dani Sancas [email protected]
On-behalf-of: @clarityai-eng [email protected]
Signed-off-by: Tatiana Ovary [email protected]