Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helpful error message for incorrect PyPI URL #509

Merged
merged 14 commits into from
Oct 30, 2019
Merged

Add helpful error message for incorrect PyPI URL #509

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
6018c11
Add helpful error message for incorrect repository URL
adityasaky Oct 6, 2019
a7780bf
Update 405 check - change URL test, error message
adityasaky Oct 7, 2019
ec53ae8
Move check_status_code to commands/upload; add corresponding test
adityasaky Oct 7, 2019
ea8d010
Import repository constants from utils; use them in 410 check; update…
adityasaky Oct 8, 2019
d2cc71d
Add pytest.mark.parametrize to try both upload.pypi and test.pypi as …
adityasaky Oct 8, 2019
a31ba7b
Add a line pointing users to --repository-url value as source of error
adityasaky Oct 8, 2019
9068268
Add exception for E405; add test for E410
adityasaky Oct 12, 2019
1a9d5e0
Fix formatting; make 405 error message more descriptive
adityasaky Oct 13, 2019
cf837a9
Update E410 check for URL
adityasaky Oct 13, 2019
751e7ed
Address review -import modules instead of specific items
adityasaky Oct 28, 2019
5df08cb
Address review - docstring PEP257 compliance
adityasaky Oct 28, 2019
05d3783
Linter - fix line lengths
adityasaky Oct 28, 2019
98c0d30
Address review - PEP257, style changes
adityasaky Oct 28, 2019
360eb5a
Move check_status_code back to utils; move tests
adityasaky Oct 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions twine/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,15 @@ def check_status_code(response, verbose):
"(or https://test.pypi.org/legacy/) to upload your packages "
"instead. These are the default URLs for Twine now. More at "
"https://packaging.python.org/guides/migrating-to-pypi-org/ ")
if (response.status_code == 405 and
response.url.startswith(("https://pypi.org",
"https://test.pypi.org"))):
print("You probably want one of these two URLs: {} or {}. Check {} for"
" more information.".format(
"https://pypi.org/legacy/",
"https://test.pypi.org/legacy/",
"https://warehouse.readthedocs.io/api-reference/legacy/"
"#upload-api"))
try:
response.raise_for_status()
except HTTPError as err:
Expand Down