Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't create tag automatically on bumping version number #197

Merged
merged 1 commit into from
May 1, 2024

Conversation

takluyver
Copy link
Member

I need to make the version number change in a PR, but I'd like the tag to point to the merge commit when I merge the PR, so I'll make it manually.

@takluyver takluyver added this to the 1.2 milestone Apr 30, 2024
@takluyver takluyver merged commit 261e4d8 into main May 1, 2024
39 checks passed
@takluyver takluyver deleted the bumpversion-no-tag branch May 1, 2024 06:40
@webknjaz
Copy link
Member

I like doing this automatically post PyPI release: https://github.com/ansible/awx-plugins/blob/e613d5a/.github/workflows/ci-cd.yml#L828-L923. Since it's the point of no return that the tag wouldn't be deleted if upload happened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants