Read RECORD from wheel file directly during install #8537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces our dependence on disk files, and removes some complexity around Python 2/3 compatibility with the csv module.
chrahunt
added
type: refactor
chrahunt
changed the title
pradyunsg
approved these changes
Jul 4, 2020
|
Thank you again. :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were reading
RECORDfrom disk after copying it to the installation destination. This is a little roundabout, and makes it harder to refactor our wheel installation logic since it must happen after copying the files over. Now we readRECORDfrom the wheel directly, so we can be much more flexible in our approach.Progresses #6030.