Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix normalize path for Windows #8062

Merged
merged 1 commit into from
May 23, 2020
Merged

fix normalize path for Windows #8062

merged 1 commit into from
May 23, 2020

Conversation

cjc7373
Copy link
Contributor

@cjc7373 cjc7373 commented Apr 16, 2020

Fixes #7625

@uranusjr
Copy link
Member

A news file would be nice since this is fixing a bug that users would want to know about.

@cjc7373 cjc7373 marked this pull request as ready for review April 16, 2020 14:08
@uranusjr
Copy link
Member

I wonder if it is possible to add a test for this. Probably not since we can’t know (without complex poking) whether the test site has another disk drive we can use 😐

@xppt Would it be able for you to try out this fix and see whether it fixes the problem?

@cjc7373
Copy link
Contributor Author

cjc7373 commented Apr 17, 2020

@uranusjr I've tested python [...]\src\pip install gevent==1.5a4 --no-binary gevent (refer to #7625 (comment)), no error occurred.
As for the test, not sure how to do it..

@xppt
Copy link

xppt commented Apr 25, 2020

Sorry it took me so long to try the fix.
I've been able to reproduce the issue on revision ee3e079~ (parent), but not on ee3e079 itself.
Seems fixed to me.

@pradyunsg pradyunsg added OS: windows Windows specific type: enhancement Improvements to functionality labels Apr 27, 2020
@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will be eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label May 19, 2020
@pradyunsg
Copy link
Member

Reminder that this PR needs to be updated.

@pypa-bot pypa-bot removed the needs rebase or merge PR has conflicts with current master label May 22, 2020
@cjc7373
Copy link
Contributor Author

cjc7373 commented May 22, 2020

Updated. (Since the normpath function has been deleted I applied my change to _fs_to_record_path function)

@pradyunsg pradyunsg merged commit 642fb07 into pypa:master May 23, 2020
@cjc7373 cjc7373 deleted the issue_7625 branch May 23, 2020 13:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
OS: windows Windows specific type: enhancement Improvements to functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to install package on different logical disk
8 participants