Move operations.prepare.Downloader (and friends) to network.download.Downloader #7431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrahunt
added
type: refactor
chrahunt
changed the title
When we factor out tests these will be needed in both sets, and it's easier to refactor tests later if we avoid creating a dependency between test files.
This will be home to Dowloader, Download, and associated helper functions. Since this is an abstraction over PipSession, it makes sense to keep these functions in a separate module. Also move a helper function here from operations.prepare.
chrahunt
force-pushed
the
refactor/operations-prepare-2
branch
from
b8668da to
c276b0e
Compare
Since we're moving functions to a file with stricter typing, this prevents mypy from complaining that our string is possibly None.
This will help us move Downloader construction out of RequirementPreparer, reducing its concerns and making it easier to test in isolation.
chrahunt
force-pushed
the
refactor/operations-prepare-2
branch
from
c276b0e to
78a221c
Compare
xavfernandez
approved these changes
Dec 5, 2019
pradyunsg
approved these changes
Dec 5, 2019
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will let us move the construction of the
Downloaderout ofRequirementPreparerwithout creating a dependency onoperations.prepare.Progresses #7049.