Cleanup operations.prepare more #7384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of computing hashes on-the-fly we do it after fully downloading the file. This step will let us move hash checking to a higher-level function without introducing a lot of complexity.
A plain loop is easier to follow than chained generators consumed by a helper function, and reduces the number of objects being passed around just to download a file.
chrahunt
added
type: refactor
This abstraction will let us hide details about the actual downloading and display of progress from most of operations.prepare.
Reduces exposure of session and progress_bar.
Reduces scope of session and progress_bar.
This simplifies the work done in the operations.prepare helper functions and also opens up the door to remove session and progress_bar from RequirementPreparer itself.
Just one step away from pulling this out of operations.prepare altogether.
chrahunt
force-pushed
the
refactor/cleanup-prepare-3
branch
from
dc99e1a to
59f2206
Compare
xavfernandez
approved these changes
Nov 22, 2019
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some basic information hiding so it is less onerous to split up
RequirementPreparer.Progresses #7049.