Send client certificate when using --trusted-host #7289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrahunt
force-pushed
the
bugfix/send-client-cert
branch
4 times, most recently
from
cf7e85c to
e037c94
Compare
chrahunt
force-pushed
the
bugfix/send-client-cert
branch
from
e037c94 to
3125c32
Compare
|
Thanks. :) I'll probably clean a few things up in a follow-up, I just need to find more issues we can use these helpers for. |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when using
InsecureHTTPAdapterwe were not properly propagating the cert info to our connection object, now we do.In order to test this, we also now have some helper functions for bringing up an HTTP(S) server (based on werkzeug) and managing certificates (with cryptography). This should help us progress on #259.
Fixes #7207.