Fix #4733 by deleting the failing example #6007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smartsammler
force-pushed
the
fix-iss4733
branch
from
b0d8c81 to
744626e
Compare
| @@ -846,7 +846,6 @@ Examples | |||
| $ pip install SomePackage[PDF] | |||
| $ pip install git+https://git.repo/some_pkg.git#egg=SomePackage[PDF] | |||
| $ pip install SomePackage[PDF]==3.0 | |||
| $ pip install -e .[PDF]==3.0 # editable project in current directory | |||
There was a problem hiding this comment.
How about changing the example to $ pip install -e .[PDF] # editable project in current directory instead?
There was a problem hiding this comment.
Thanks for the hint.
This example did not make sense unless it was possible to install specify a version of a package one installs referencing by the path (here: `.`). A new example for the local installation with an extra has been added instead.
smartsammler
force-pushed
the
fix-iss4733
branch
from
744626e to
f92ac73
Compare
xavfernandez
approved these changes
Nov 12, 2018
|
Thanks @smartsammler for the PR and @xavfernandez + @benoit-pierre for the reviews! :D |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This example did not make sense unless it was possible to install specify a
version of a package one installs referencing by the path (here:
.) .No news file, because it is a trivial fix.