-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--install-option bleeds to next dependency in requiremets.txt #4453
Labels
auto-locked
Outdated issues that have been locked by automation
C: requirement file
Using `requirements.txt`
type: bug
A confirmed bug or unintended behavior
Comments
+1 |
Related to #4118 |
Related to #3830? |
+1 |
Another problem: it disallows usage of wheels for all packages. |
This is the same issue as reported in #3763. I just reproduced it on my machine, with the latest master. |
simnalamburt
added a commit
to devsisters/pip
that referenced
this issue
Feb 1, 2018
Prevent '--install-option' and '--global-option' from leaking into the next dependencies in the 'requirements.txt' file. You should not mutate the parameters provided by the caller unless you are aware of what you're doing. # BAD! Mutating the parameter! def bad(param): param += ['a'] # OK. Binding a new object to the name. def good(param): param = param + ['a'] Fixes pypa#3763, pypa#3830, and pypa#4453. Reference: https://github.com/simnalamburt/snippets/blob/master/python/pip-4453.py
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
auto-locked
Outdated issues that have been locked by automation
C: requirement file
Using `requirements.txt`
type: bug
A confirmed bug or unintended behavior
Description:
Try to add --install-option to a dependency inside requirements.txt
What I've run:
Current requirements file:
pip install -r requirements.txt
output:
If I change the file to:
Output:
The text was updated successfully, but these errors were encountered: