Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand Array API coverage for Numba backend #691

Merged
merged 13 commits into from
Jun 3, 2024

Conversation

hameerabbasi
Copy link
Collaborator

No description provided.

@hameerabbasi hameerabbasi requested a review from mtsokol May 30, 2024 06:30
Copy link

codecov bot commented May 30, 2024

Codecov Report

Attention: Patch coverage is 88.54167% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 89.98%. Comparing base (cb6b604) to head (a9c01db).
Report is 56 commits behind head on main.

Current head a9c01db differs from pull request most recent head 0f244eb

Please upload reports for the commit 0f244eb to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #691      +/-   ##
==========================================
- Coverage   90.21%   89.98%   -0.23%     
==========================================
  Files          20       22       +2     
  Lines        3670     3766      +96     
==========================================
+ Hits         3311     3389      +78     
- Misses        359      377      +18     

@hameerabbasi hameerabbasi force-pushed the numba-fix-signatures branch from a507b60 to 5c028b2 Compare May 30, 2024 06:50
@hameerabbasi hameerabbasi enabled auto-merge (squash) May 30, 2024 10:15
@hameerabbasi hameerabbasi changed the title Fix signatures for a few functions. Expand Array API coverage for Numba backend Jun 3, 2024
@hameerabbasi hameerabbasi disabled auto-merge June 3, 2024 06:08
@hameerabbasi hameerabbasi force-pushed the numba-fix-signatures branch from e8cd836 to cd6acaa Compare June 3, 2024 07:09
Copy link
Collaborator

@mtsokol mtsokol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only docs are failing with one warning. I'm not sure if that's the fix but here are two suggestions.

@hameerabbasi hameerabbasi force-pushed the numba-fix-signatures branch from 1cf01c9 to c7a051d Compare June 3, 2024 10:39
@hameerabbasi hameerabbasi requested a review from mtsokol June 3, 2024 11:07
@hameerabbasi
Copy link
Collaborator Author

The docs were failing due to isfinite being a ufunc, and Sphinx not knowing how to generate docs for it. I removed it from the list and doc generation works again.

@hameerabbasi hameerabbasi force-pushed the numba-fix-signatures branch from 3573f54 to a9c01db Compare June 3, 2024 14:18
@hameerabbasi hameerabbasi requested a review from mtsokol June 3, 2024 14:21
@hameerabbasi hameerabbasi force-pushed the numba-fix-signatures branch from a9c01db to 0f244eb Compare June 3, 2024 14:23
@hameerabbasi hameerabbasi enabled auto-merge (squash) June 3, 2024 14:38
@hameerabbasi hameerabbasi merged commit 7892670 into pydata:main Jun 3, 2024
13 checks passed
@hameerabbasi hameerabbasi deleted the numba-fix-signatures branch June 3, 2024 14:43
@DeaMariaLeon DeaMariaLeon added the enhancement Indicates new feature requests label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Indicates new feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants