Hopefully add Window / MacOS PyPy 3.10 / 3.11 support #12559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandernst
force-pushed
the
44.0.x
branch
3 times, most recently
from
ee47bc3 to
ea3a1a3
Compare
alex
reviewed
Mar 6, 2025
.github/workflows/ci.yml
Outdated
| - WINDOWS: {ARCH: 'x86', WINDOWS: 'win32'} | ||
| PYTHON: {VERSION: "pypy-3.10", NOXSESSION: "tests-nocoverage"} | ||
| - WINDOWS: {ARCH: 'x86', WINDOWS: 'win32'} | ||
| PYTHON: {VERSION: "pypy-3.11", NOXSESSION: "tests-nocoverage"} |
There was a problem hiding this comment.
In general, backport branches should match what's on main for whatever they're backporting. In this case we don't test pypy on macOS and Windows, so that shouldn't be included here.
There was a problem hiding this comment.
Got it! I submitted a new patch!
There was a problem hiding this comment.
This part doesn't seem to have been removed.
There was a problem hiding this comment.
I don't see it in the diff 🤔
alex
reviewed
Mar 6, 2025
.github/workflows/ci.yml
Outdated
| @@ -303,6 +305,8 @@ jobs: | |||
| PYTHON: | |||
| - {VERSION: "3.7", NOXSESSION: "tests-nocoverage"} | |||
| - {VERSION: "3.13", NOXSESSION: "tests"} | |||
| - {VERSION: "pypy-3.10", NOXSESSION: "tests-nocoverage"} | |||
| - {VERSION: "pypy-3.11", NOXSESSION: "tests-nocoverage"} | |||
There was a problem hiding this comment.
Oohh, sorry, I totally misunderstood you. I thought you were only talking about the chunk which prevented the CI from testing on winx86.
Fixed!
Don't exclude win_x86 . .
alex
approved these changes
Mar 7, 2025
|
I'm not going to cut a release right away, unless there's an immediate need for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds wheels for Windows and MacOS for PyPy 3.11.
I also took the liberty to improve a little bit the
excludesection in the CI in order to spare some useless runs. 🙏There is 1 workflow that is failing, the linux+py3.12+rust-nightly, which I'm guessing is because of the rust-nightly (?).